Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose EditorView up to the parent component after initialization #31

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

mattyg
Copy link
Contributor

@mattyg mattyg commented Feb 9, 2024

Thanks for this great component!

I need to be able to access the EditorView in my parent component. This PR makes the CodeMirror component dispatch a 'ready' event that includes the EditorView, after it has been initialized.

@mattyg
Copy link
Contributor Author

mattyg commented Feb 15, 2024

any chance of getting this merged @SomaticIT

@rouzwelt
Copy link

yup I came across this issue before, that needing to somehow access the EditorView from this svelte plugin, would be great if this can be merged

@rouzwelt
Copy link

rouzwelt commented Feb 20, 2024

hey @SomaticIT , have you checked this PR? and what's your thoughts on it? do you think you can merge this? would really appreciate it if we can get a resolution for this soon

@SomaticIT
Copy link
Contributor

Hello,
I'm sorry for the delay of my response.
This PR sounds very cool and is perfectly aligned with your needs without compromising common use cases.
Let me merge it and create a release!
Thanks

@SomaticIT SomaticIT merged commit 409cae6 into touchifyapp:main Feb 27, 2024
2 checks passed
Copy link

🎉 This PR is included in version 1.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mattyg
Copy link
Contributor Author

mattyg commented Mar 15, 2024

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants